saveUIState()'s javadocs needs to be updated (since its 'keepCancelEnabled' parameter got removed). There's probably some code we can can out as a result of this change like the 'cancelListener' field and the 'cancelPressed()' method. Not too gung-ho on the static ImageDescriptor idea though that could just be me.Ģ. The stopped(Object) method also needs to change.ġ. Being able to click on something with the clock cursor is counterintuitive in my opinion. At the moment I get a clock cursor when I'm hovering over the stop button. This is still done though it should be set on the stop button instead. The CURSOR_ARROW cursor is set to the cancel button in the aboutToStart(boolean) method. The returned image must be explicitly disposed using the image's dispose call."Ģ. Note that each call returns a new SWT image object. "Creates and returns a new SWT image for this image descriptor. The createImage() API mandates that the returned Image instance be disposed by the client. I've applied the patch locally and played around with it on Linux/gtk+, comments as follows:ġ. Thanks for the patch and redesign, Eugene! As others have said, this makes the wizard design much clearer to users, thank you for your contribution. Previous patch + implemented previous comment This is how the wizard looks with "higher progress bar" patch Patch that adds a new stop image to fix alignment Restored the initialize(.Layout, int) method
0 kommentar(er)
